Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Order index fixes #5388

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[admin] Order index fixes #5388

merged 2 commits into from
Sep 19, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 19, 2023

Summary

The page title was missing and "Balance due" badges were breaking in two lines.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested a review from a team as a code owner September 19, 2023 15:30
@elia elia self-assigned this Sep 19, 2023
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem changelog:repository Changes to the repository not within any gem changelog:solidus_admin labels Sep 19, 2023
@elia elia changed the base branch from main to nebulab/admin September 19, 2023 15:31
@elia elia requested a review from rainerdema September 19, 2023 15:32
@elia elia removed changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem changelog:repository Changes to the repository not within any gem labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #5388 (cc0cb3c) into nebulab/admin (f4c0dc2) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           nebulab/admin    #5388   +/-   ##
==============================================
  Coverage          88.87%   88.87%           
==============================================
  Files                615      615           
  Lines              14861    14861           
==============================================
  Hits               13208    13208           
  Misses              1653     1653
Files Changed Coverage Δ
...app/components/solidus_admin/ui/badge/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit f8a8304 into nebulab/admin Sep 19, 2023
4 checks passed
@elia elia deleted the elia/admin/order-index-fixes branch September 19, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema